Skip to content

Conversation

@JZDesign
Copy link
Contributor

@JZDesign JZDesign commented Nov 13, 2025

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

Motivation

Users want to be able to customize their paywall based on varying things like screen orientation, screen size, offer eligibility, etc.,

Description

configures our component overrides engine to handle more cases

@emerge-tools
Copy link

emerge-tools bot commented Nov 13, 2025

2 builds increased size

Name Version Download Change Install Change Approval
RevenueCat
com.revenuecat.PaywallsTester
1.0 (1) 16.6 MB ⬆️ 47.3 kB (0.29%) 58.9 MB ⬆️ 196.7 kB (0.34%) N/A
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac
1.0 (1) 12.3 MB ⬆️ 45.0 kB (0.37%) 44.7 MB ⬆️ 169.9 kB (0.38%) N/A

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 196.7 kB (0.34%)
Total download size change: ⬆️ 47.3 kB (0.29%)

Largest size changes

Item Install Size Change
DYLD.String Table ⬆️ 77.5 kB
📝 RevenueCatUI.ScreenCondition.ScreenCondition ⬆️ 10.5 kB
Code Signature ⬆️ 5.1 kB
DYLD.Exports ⬆️ 4.8 kB
RevenueCatUI.VideoComponentViewModel.VideoComponentViewModel ⬆️ 3.6 kB
View Treemap

Image of diff

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 169.9 kB (0.38%)
Total download size change: ⬆️ 45.0 kB (0.37%)

Largest size changes

Item Install Size Change
DYLD.String Table ⬆️ 53.8 kB
📝 RevenueCatUI.ScreenCondition.ScreenCondition ⬆️ 10.6 kB
DYLD.Exports ⬆️ 4.8 kB
Code Signature ⬆️ 4.8 kB
RevenueCatUI.VideoComponentViewModel.VideoComponentViewModel ⬆️ 3.5 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@emerge-tools
Copy link

emerge-tools bot commented Nov 13, 2025

📸 Snapshot Test

476 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
RevenueCat
com.revenuecat.PaywallsTester
0 0 0 0 238 0 N/A
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac
0 0 0 0 238 0 N/A

🛸 Powered by Emerge Tools

@JZDesign JZDesign marked this pull request as ready for review November 14, 2025 21:13
@JZDesign JZDesign requested review from a team as code owners November 14, 2025 21:13
facumenzella and others added 2 commits November 26, 2025 15:08
* Add default values for IntroOffer and MultipleIntroOffers

* fixed test
…imension (#5894)

* correct the rotation update issue

* Always use shorter dimension to calculate screen size category

public var colors: [String: PaywallComponent.ColorScheme]
public var fonts: [String: FontsConfig]
public var screenSizes: [ScreenSize]?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this one optional? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Khepri didn't have this in there when I wrote this code, and it may not yet even… I made tickets for that work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When talking with Josh, getting it out and working was priority. Adding the ability to customize the screen sizes was another thing we were going to work on separately.


#if !os(tvOS) // For Paywalls V2

public struct UIConfig: Codable, Equatable, Sendable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: We could totally make this spi at some point, right?

@JZDesign JZDesign marked this pull request as draft December 4, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants