-
Notifications
You must be signed in to change notification settings - Fork 404
Conditional Visibility #5794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conditional Visibility #5794
Conversation
2 builds increased size
RevenueCat 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 77.5 kB |
| 📝 RevenueCatUI.ScreenCondition.ScreenCondition | ⬆️ 10.5 kB |
| Code Signature | ⬆️ 5.1 kB |
| DYLD.Exports | ⬆️ 4.8 kB |
| RevenueCatUI.VideoComponentViewModel.VideoComponentViewModel | ⬆️ 3.6 kB |
RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 169.9 kB (0.38%)
Total download size change: ⬆️ 45.0 kB (0.37%)
Largest size changes
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 53.8 kB |
| 📝 RevenueCatUI.ScreenCondition.ScreenCondition | ⬆️ 10.6 kB |
| DYLD.Exports | ⬆️ 4.8 kB |
| Code Signature | ⬆️ 4.8 kB |
| RevenueCatUI.VideoComponentViewModel.VideoComponentViewModel | ⬆️ 3.5 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
📸 Snapshot Test476 unchanged
🛸 Powered by Emerge Tools |
…nto jzdesign/MON-1196
* Revert intro_offer rename * remove extra test
* Add default values for IntroOffer and MultipleIntroOffers * fixed test
…imension (#5894) * correct the rotation update issue * Always use shorter dimension to calculate screen size category
|
|
||
| public var colors: [String: PaywallComponent.ColorScheme] | ||
| public var fonts: [String: FontsConfig] | ||
| public var screenSizes: [ScreenSize]? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this one optional? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Khepri didn't have this in there when I wrote this code, and it may not yet even… I made tickets for that work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When talking with Josh, getting it out and working was priority. Adding the ability to customize the screen sizes was another thing we were going to work on separately.
|
|
||
| #if !os(tvOS) // For Paywalls V2 | ||
|
|
||
| public struct UIConfig: Codable, Equatable, Sendable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: We could totally make this spi at some point, right?


Checklist
purchases-androidand hybridsMotivation
Users want to be able to customize their paywall based on varying things like screen orientation, screen size, offer eligibility, etc.,
Description
configures our component overrides engine to handle more cases