-
Notifications
You must be signed in to change notification settings - Fork 405
Track customer center purchases through paywalls #5691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
facumenzella
wants to merge
6
commits into
main
Choose a base branch
from
feat/paywall-source
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
16e6383
Track customer center purchases
facumenzella 05b03df
simplified logic
facumenzella 5205282
add spiinternal
facumenzella 37e9ddd
Merge branch 'main' into feat/paywall-source
facumenzella f6aef6d
fixed tests
facumenzella a9885c2
pod lib lint
facumenzella File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // swiftlint:disable missing_docs | ||
| // | ||
| // PaywallSource.swift | ||
| // | ||
| // | ||
| // Created by RevenueCat on 2/26/25. | ||
| // | ||
|
|
||
| /// Identifies where a paywall was presented from so that backend analytics can classify the event. | ||
| @_spi(Internal) public struct PaywallSource: RawRepresentable, Hashable, Sendable, ExpressibleByStringLiteral { | ||
|
|
||
| /// Raw backend identifier describing the source. | ||
| public let rawValue: String | ||
|
|
||
| public typealias StringLiteralType = String | ||
|
|
||
| /// Creates a typed paywall source from a raw backend identifier. | ||
| public init(rawValue: String) { | ||
| self.rawValue = rawValue | ||
| } | ||
|
|
||
| /// Allows initializing from string literals (e.g. `PaywallSource("foo")`). | ||
| public init(stringLiteral value: StringLiteralType) { | ||
| self.init(rawValue: value) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| @_spi(Internal) public extension PaywallSource { | ||
|
|
||
| /// Source identifier used when the paywall originated from Customer Center. | ||
| static let customerCenter: PaywallSource = "presented_from_customer_center" | ||
|
|
||
| } | ||
| // swiftlint:enable missing_docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // | ||
| // PaywallSourceEnvironment.swift | ||
| // | ||
| // | ||
| // Created by RevenueCat on 2/26/25. | ||
| // | ||
|
|
||
| #if canImport(SwiftUI) | ||
|
|
||
| import SwiftUI | ||
|
|
||
| #if !os(tvOS) | ||
|
|
||
| @available(iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0, *) | ||
| private struct PaywallSourceKey: EnvironmentKey { | ||
|
|
||
| static let defaultValue: PaywallSource? = nil | ||
|
|
||
| } | ||
|
|
||
| @available(iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0, *) | ||
| extension EnvironmentValues { | ||
|
|
||
| /// The optional paywall source available in the current environment. | ||
| @_spi(Internal) public var paywallSource: PaywallSource? { | ||
| get { self[PaywallSourceKey.self] } | ||
| set { self[PaywallSourceKey.self] = newValue } | ||
| } | ||
| } | ||
|
|
||
| @available(iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0, *) | ||
| extension View { | ||
|
|
||
| /// Associates the provided paywall source with this view hierarchy so downstream paywall presentations can read it. | ||
| @_spi(Internal) public func paywallSource(_ source: PaywallSource?) -> some View { | ||
| self.environment(\.paywallSource, source) | ||
| } | ||
|
Comment on lines
+35
to
+37
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This felt cleaner than adding a parameter to the view |
||
|
|
||
| } | ||
|
|
||
| #endif | ||
|
|
||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to rever this file