Skip to content

Conversation

@ucswift
Copy link
Member

@ucswift ucswift commented Sep 8, 2025

Summary by CodeRabbit

  • Chores
    • Internal builds now use the “internal” distribution channel for delivery to testers and QA.
    • The internal build environment is now labeled “Internal” (previously “Development”), affecting configuration and in-app identifiers for that variant.
    • Improves clarity for internal users when distinguishing app variants during testing.
    • No impact on production users.

@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

Walkthrough

Updated EAS build configuration for the "internal" profile in eas.json by setting distribution to "internal" and changing APP_ENV from "development" to "internal". No code or API surface changes.

Changes

Cohort / File(s) Summary of Changes
EAS config
eas.json
In the internal build profile: added "distribution": "internal"; updated environment variable APP_ENV from "development" to "internal"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at configs fine,
Internal builds now cleanly align.
From dev to internal, flags set right—
Carrot-colored pipelines take flight.
Hoppity hops through JSON land,
Shipping nibble-sized tweaks as planned.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift
Copy link
Member Author

ucswift commented Sep 8, 2025

Approve

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit 6514bd1 into master Sep 8, 2025
10 of 11 checks passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a4ff56 and 019c3ad.

📒 Files selected for processing (1)
  • eas.json (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test
🔇 Additional comments (1)
eas.json (1)

54-54: LGTM on switching to internal distribution for the "internal" profile

This aligns with ad-hoc/enterprise-style installs. Please confirm:

  • iOS: Apple credentials and tester device UDIDs (or enterprise cert) are set in EAS.
  • Android: APK artifact is intended for sideloading (matches buildType: apk).

},
"env": {
"APP_ENV": "development",
"APP_ENV": "internal",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Changing APP_ENV to "internal"—verify runtime support

Ensure the app’s config/routes/feature flags handle APP_ENV="internal" (not just production/staging/development), otherwise builds may misconfigure endpoints or keys.

Run this to verify handling in the repo:


🏁 Script executed:

#!/bin/bash
# Where is APP_ENV read?
rg -nP -C2 '\bAPP_ENV\b' --type-add 'tsx:*.tsx' --type-add 'ts:*.ts' --type-add 'jsx:*.jsx' --type-add 'js:*.js'

# Do we explicitly handle "internal"?
rg -nP -C2 '\binternal\b' --type=ts --type=tsx --type=js --type=jsx

# Any env mapping that might still point "internal" to development?
rg -nP -C2 'APP_ENV.*(development|staging|production)' --type=ts --type=tsx --type=js --type=jsx

# Any dotenv usage that could conflict with EXPO_NO_DOTENV=1?
rg -nP -C2 '(dotenv|react-native-dotenv|process\.env\.)' --type=ts --type=tsx --type=js --type=jsx

Length of output: 6666


🏁 Script executed:

#!/bin/bash
find . -maxdepth 1 -type f -name ".env.*" -print

Length of output: 18


Ensure a .env.internal file exists with all required variables
env.js loads .env.${APP_ENV} (via path.resolve) and its Zod schema includes "internal", but only .env.development is present—without .env.internal, internal builds will fail.

🤖 Prompt for AI Agents
In eas.json around line 63, APP_ENV is set to "internal" but there is no
corresponding .env.internal file; ensure a .env.internal file exists at the
project root containing all environment variables required by env.js/Zod schema
(match keys and formats used in other .env.* files), or change APP_ENV to an
existing environment (e.g., "development") if "internal" is not intended; add
the .env.internal file to version control or CI secrets as appropriate so
internal builds can load it via path.resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants