fix: handle multi-value custom fields in AI context builder#129
Merged
ManukMinasyan merged 1 commit intomainfrom Feb 16, 2026
Merged
fix: handle multi-value custom fields in AI context builder#129ManukMinasyan merged 1 commit intomainfrom
ManukMinasyan merged 1 commit intomainfrom
Conversation
Prevent "Array to string conversion" when RecordContextBuilder returns array values for multi-value fields like domains. Add implode() in both RecordContextBuilder and RecordSummaryService, with a regression test.
There was a problem hiding this comment.
Pull request overview
Fixes AI context/prompt building when custom fields return multi-value arrays (e.g., company domains), preventing “Array to string conversion” errors and ensuring consistent string output for basic info.
Changes:
- Convert multi-value
domainscustom field values into a comma-separated string inRecordContextBuilder::getCompanyBasicInfo(). - Add defensive array-to-string conversion in
RecordSummaryService::addBasicInfo()when formatting the prompt. - Add a regression test asserting multi-value company domains are emitted as a string in
basic_info.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/Feature/AI/RecordSummaryServiceTest.php |
Adds regression coverage for multi-value custom field output in the context builder. |
app/Services/AI/RecordSummaryService.php |
Prevents array-to-string conversion errors when basic info values are arrays during prompt formatting. |
app/Services/AI/RecordContextBuilder.php |
Ensures company domains are rendered as a comma-separated string in basic_info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecordContextBuilderreturns array values for multi-value fields likedomainsimplode()handling in bothRecordContextBuilder::getCompanyBasicInfo()andRecordSummaryService::addBasicInfo()Test plan
php artisan test --compact tests/Feature/AI/RecordSummaryServiceTest.php— 17 passed