-
Notifications
You must be signed in to change notification settings - Fork 0
fix: date in tabella per trasparenza #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mamico
wants to merge
10
commits into
main
Choose a base branch
from
trasparenza_table_date
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
19b584a
fix: date in tabella per trasparenza
mamico c62a5a1
fix datetime
mamico 1d55b48
fix: add utc timezone
mamico 1c761c4
fix: date with timezone
mamico da1ea69
chorre: remove console.log
mamico 045ba99
cleanup
mamico ac057ab
Update src/components/Blocks/Listing/Table/TableTemplate.jsx
mamico ab02cd2
Update src/components/Blocks/Listing/Table/TableTemplate.jsx
mamico 7676e78
docs
mamico a6bbc60
do not change shared state
mamico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
src/customizations/volto/components/theme/Widgets/DatetimeWidget.jsx
mamico marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /* | ||
| * customization from @plone/volto 18.9.1 | ||
| * | ||
| * show time using the server timezone | ||
| * | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import cx from 'classnames'; | ||
| import moment from 'moment-timezone'; | ||
| import { useSelector } from 'react-redux'; | ||
| import { toBackendLang } from '@plone/volto/helpers/Utils/Utils'; | ||
|
|
||
| const DatetimeWidget = ({ value, children, className, format = 'lll' }) => { | ||
| const lang = useSelector((state) => state.intl.locale); | ||
| const tz = useSelector( | ||
| (state) => state.site?.data?.['plone.portal_timezone'] ?? 'Europe/Rome', | ||
| ); | ||
| moment.locale(toBackendLang(lang)); | ||
| return value ? ( | ||
| <span className={cx(className, 'datetime', 'widget')}> | ||
| {children | ||
| ? children(moment.tz(value, tz).format(format)) | ||
| : moment.tz(value, tz).format(format)} | ||
| </span> | ||
| ) : ( | ||
| '' | ||
| ); | ||
| }; | ||
|
|
||
| export default DatetimeWidget; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possiamo importarlo lazy? Non ho guardato come sia stato importato altrove nel repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
il lavoro di avere moment lazy su Volto è un lavoro "a metà", fare una libreria lazy "a metà" è più la perdita che il guadagno. Però, nello specifico qui posso faare moment-timezone lazy e vedere se c'è un guadagno reale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sposto la verifica per il lazy su una issue a parte