RHINENG-24144: Fix JOB_NAME slash issue in build_deploy.sh for GitHub…

[saurabhpimpalgaokar123]

… Branch Source

PR Title 💥

Please title this PR with a summary of the change, along with the JIRA card number.

Suggested formats:

1. Fixes/Refs #RHIROS-XXX - Title
2. RHIROS-XXX Title

Feel free to remove this section from PR description once done.

Why do we need this change? 💭

Please include the context of this change here.

Documentation update? 📝

• Yes
• No

Security Checklist 🔒

Upon raising this PR please go through RedHatInsights/secure-coding-checklist

💂‍♂️ Checklist 🎯

• Bugfix
• New Feature
• Refactor
• Unittests Added
• DRY code
• Dependency Added
• DB Migration Added

ROS RHEL GitHub label usage for executing a desired test suite

Select the appropriate GitHub label to control which ROS RHEL backend tests run for this PR (Labels can be added before or after commits are pushed):

Note: Changing a Label on a PR with an already-tested commit will not trigger a new test run

Available ROS RHEL labels:

• test-backend-v1: Run legacy backend tests only
• test-backend-v2: Run new backend tests only
• test-backend-both: Run both backend tests

Additional 📣

Feel free to add any other relevant details such as links, notes, screenshots, here.

Summary by Sourcery

Bug Fixes:

• Prevent failures in temporary directory creation when Jenkins JOB_NAME contains forward slashes by normalizing the name in build_deploy.sh.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Escapes slashes in JOB_NAME when constructing the temporary job directory name in build_deploy.sh to avoid invalid path issues.

File-Level Changes

Change	Details	Files
Sanitize JOB_NAME when creating the temporary job directory so that slashes are replaced with dashes.	Adjust mktemp template string to use a parameter expansion that replaces all '/' characters in JOB_NAME with '-' Preserve existing tmp directory location, prefix, and BUILD_NUMBER usage while only altering the JOB_NAME component	build_deploy.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[LightOfHeaven1994]

Looks good @saurabhpimpalgaokar123