Skip to content

Conversation

@andhie
Copy link

@andhie andhie commented Feb 8, 2017

The current API to create a HashMap<String, Object> and manually adding each key and value pair.
This method is simple but creates few issues in consuming the API.

  1. Current method does not easily communicate the expected value. The Value placed can be anything, it maybe a String, Boolean, or even a String[].
  2. This easily creates confusion and add in wrong values which may crash the SDK since the SDK does not perform type checking.
  3. To apply the correct values, developers would have to go thru docs that are not mobile specific. Even so, the values may not have example or easily discovered.
  4. Certain variable negates another variable effect or only takes effect when a specific variable is set. e.g. mp_editing_enabled=true and mp_bill_name_edit_disabled=true

@clewlb
Copy link
Contributor

clewlb commented Feb 8, 2017

Thanks for the effort and time, we will consider to include this in our next major release.

@andhie
Copy link
Author

andhie commented Feb 8, 2017

Its your choice of including it. When i created it i assumed it as a drop-in from the Example code. Devs may choose to use the current method or use Builders.
The Builders does add some method count (64k limit), thats why i add it in the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants