Skip to content

Conversation

@mzuenni
Copy link
Collaborator

@mzuenni mzuenni commented Dec 15, 2025

Closes #487.

Try to implement new sample data behaviour

@mzuenni
Copy link
Collaborator Author

mzuenni commented Dec 15, 2025

@thorehusfeldt can you check the schema again? ^^'

@mpsijm mpsijm changed the title Sample data #487 Implement new sample override Dec 15, 2025
Copy link
Collaborator

@mpsijm mpsijm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code review, didn't test it yet. The CUE schema looks good on first glance (maybe I'd put "ans" before "ans.statement" for consistency, but that's a nit). Note that the JSON schema should also be updated.

@mzuenni
Copy link
Collaborator Author

mzuenni commented Dec 18, 2025

@mpsijm @thorehusfeldt can you check the schemas?

@mzuenni
Copy link
Collaborator Author

mzuenni commented Jan 11, 2026

@mpsijm can this be merged?

Copy link
Collaborator

@mpsijm mpsijm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, all is looking good to me! If the schema change was intentional and the discussion in #487 is concluded, feel free to merge 🙂

@mzuenni mzuenni requested a review from mpsijm January 13, 2026 11:30
@mzuenni
Copy link
Collaborator Author

mzuenni commented Jan 13, 2026

@mpsijm i changed the logic here a bit, do you want to take a look again?

Copy link
Collaborator

@mpsijm mpsijm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looking good to me 😄 I see you did not (need to) change the tests to match the modified logic in the last commit, which to me means that the external interface has not changed 👍 We may want to add some extra assertions (like verifying that the linked files are actually symlinks) but that may be more effort than it's worth, I'll leave that up to you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for symlinks in generators.yaml

4 participants