Add UVBeam support for the MWA Average Embedded Element (AEE) beam model#1660
Open
Add UVBeam support for the MWA Average Embedded Element (AEE) beam model#1660
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1660 +/- ##
========================================
Coverage 99.93% 99.93%
========================================
Files 67 67
Lines 22706 22864 +158
========================================
+ Hits 22692 22850 +158
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e6fac40 to
dfe08c5
Compare
dfe08c5 to
bff52e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The MWA Average Embedded Element (AEE) beam model is an older model, but it is widely used, so being able to compare it to the newer (and already supported) Full Embedded Element (FEE) beam model is important. The input files are totally different for these two models, so some real work was needed to add this support.
Motivation and Context
Types of changes
Checklist:
New feature checklist: