Conversation
|
@bhazelton I fixed the main problem and opened up testing against 3.14. Interestingly linux tests on Circle CI fail on 3.11 from a timeout (this has happened a few times now, so I don't think it's just a random networking issue). 3.14 fails everywhere but not during install but instead due to something in lunarsky. I don't know what that error means though! It looks like lunarsky is tested against 3.14 so I'm not sure what's going on. |
|
I'm fixing the python 3.11 in another branch. It seems that micromamba is not working well anymore, so I'm moving back to miniforge conda. But CI changes like this take forever to get right. So many pushes! |
|
On the lunarsky issue: I think we need a new release, there hasn't been a release since I fixed the thing that was breaking on 3.14 in that repo and added the testing against 3.14. I'll work on getting a new release out, I can't remember if I can do it or if I need to ask Adam for that. |
|
Ah! OK I mistakenly assumed that it had been released since the update. I sympathise with the CI updates :-P |
|
It might be worth considering |
|
I'm currently working on pyFHD, which was set up by another developer to use |
|
I merged the CI fix and got a new version of lunarsky out, so I'm going to rebase this and hopefully things will pass. |
db21ecb to
d781a63
Compare
|
Hmm, we're getting errors related to building python-casacore on builds that don't use conda. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1659 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 67 67
Lines 22706 22706
=======================================
Hits 22692 22692
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We also have errors on the intel mac builds. I think the numba pin is how I fixed those builds before. I'm not sure how to deal with that, I don't want to abandon building wheels for intel macs... |
|
@bhazelton it sounds like LLVM has decided not to support intel macos in its most recent versions, due to it being discontinued on github actions (??). If this is so, it would mean that we'd never be able to support 3.14+ which is of course not a reasonable path forward. Maybe the best thing to do would be to put conditional constraints on numba -- for python 3.14+ require newer versions, and just don't build the conda package for those newer versions specifically for macos intel. In that way, users of macos intel can either install an older version of pyuvdata through conda, OR install the newest version by installing LLVM themselves and using pip (e.g. https://afnan.io/posts/2018-10-01-using-the-latest-llvm-release-on-macos/) |
|
I am very happy with a conditional constraints on numba, do you know how to do that in the It turns out that numba issue is completely solved for intel macs if you use conda packages rather than pypi ones. |
|
Ok, I figured out how to do the conditional dependency specification and the mac intel builds are fixed. The remaining problem is that builds that use pypi on python 3.14 and include optional dependencies are erroring because python-casacore is failing to build on python 3.14. The way we have solved our python-casacore issues in general are that we run using conda. So at least for now, it seems like we can decide to either move these jobs to conda or only run them on 3.13. We can also add a job if you like that builds off pypi on python 3.14 without optional dependencies. Unless you have ideas about how to fix the python-casacore builds on python 3.14... |
because python-casacore does not build properly from pypi on python 3.14
|
@steven-murray ok, I changed the numba tests to not install optional dependencies because they are not needed for those tests. I also turned the warnings test into a matrix job to run one version with all dependencies under python 3.13 and one version with only the required dependencies under python 3.14. Unfortunately, while we get past the install step, there's a new error that seems to be related to cython's coverage plugin. This is the best reference I found so far: coveragepy/coveragepy#1790 I don't understand why we aren't seeing this error on the conda builds on circleci, they seem to have all the same versions of the relevant packages... |
|
ok, I turned off coverage in the warnings python 3.14 job, which seems to have let the job run without errors. |
steven-murray
left a comment
There was a problem hiding this comment.
This all looks correct to me! Thanks @bhazelton for this quick turnaround
Description
Remove the numba pin to support python 3.14
Motivation and Context
closes #1658
Types of changes
Checklist:
Build or continuous integration change checklist: