COMP: Drop use of itk::Math::Absolute to fix compilation warnings#916
Merged
SimonRit merged 1 commit intoRTKConsortium:mainfrom Mar 5, 2026
Merged
COMP: Drop use of itk::Math::Absolute to fix compilation warnings#916SimonRit merged 1 commit intoRTKConsortium:mainfrom
SimonRit merged 1 commit intoRTKConsortium:mainfrom
Conversation
Collaborator
Author
|
See discourse discussion https://discourse.itk.org/t/how-to-best-handle-itk-absolute/7724 on this topic. |
InsightSoftwareConsortium/ITK#5802 and RTKConsortium#904 have triggered new warnings such as ``` [CTest: warning matched] /home/srit/src/rtk/dashboard_tests/RTK/include/rtkJosephBackProjectionImageFilter.hxx:277:28: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare] 277 | for (int i{ 0 }; i < itk::Math::Absolute(fs - ns) - 1; ++i) ``` The new behavior is intentional but returning an unsigned is problematic in this case as we subtract 1 from it. So we now use `std::abs` throughout the code
Collaborator
Author
|
Failing test is due to recent changes in CudaCommon, will be fixed with #906 when CudaCommon is released (soon) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InsightSoftwareConsortium/ITK#5802 and #904 have triggered new warnings such as
The new behavior is intentional but returning an unsigned is problematic in this case as we subtract 1 from it. So we now use
std::absthroughout the code