Skip to content

ENH: Add optional and groups dependencies in pyproject.toml #913

Open
axel-grc wants to merge 2 commits intoRTKConsortium:mainfrom
axel-grc:pyproject
Open

ENH: Add optional and groups dependencies in pyproject.toml #913
axel-grc wants to merge 2 commits intoRTKConsortium:mainfrom
axel-grc:pyproject

Conversation

@axel-grc
Copy link
Collaborator

@axel-grc axel-grc commented Mar 3, 2026

Close #908

Copy link
Collaborator

@SimonRit SimonRit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! My understanding is that the dev one should be in dependency-groups and split into docs and test. Any reason for not doing this?

@axel-grc
Copy link
Collaborator Author

axel-grc commented Mar 3, 2026

Thanks! My understanding is that the dev one should be in dependency-groups and split into docs and test. Any reason for not doing this?

Not really, I will change that.

@axel-grc
Copy link
Collaborator Author

axel-grc commented Mar 3, 2026

From what I understand, dependency-groups is the newer standard and replace optional-dependencies.
So I used dependency-groups for gui too

@SimonRit
Copy link
Collaborator

SimonRit commented Mar 3, 2026

From what I understand, dependency-groups is the newer standard and replace optional-dependencies. So I used dependency-groups for gui too

This is not my understanding: https://pydevtools.com/handbook/explanation/what-are-optional-dependencies-and-dependency-groups/. Any resource for justifying this?

@axel-grc
Copy link
Collaborator Author

axel-grc commented Mar 3, 2026

Ok I didn't get the differences, I will change this again

@axel-grc axel-grc changed the title ENH: Add optional dev and gui dependencies in pyproject.toml ENH: Add optional and groups dependencies in pyproject.toml Mar 5, 2026
@SimonRit
Copy link
Collaborator

SimonRit commented Mar 5, 2026

It would be good to document (in INSTALLATION.md and rtkshowgeometry page) and test before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use optional-dependencies in pyproject.toml for optional Python dependencies

2 participants