Codebook csv import #165
Merged
Codebook csv import #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some todos: convert colors, report errors about malformed csv, choice of append/overwrite, include color in requal csv export, backend handling
tested manually to still be working
skvrnami
reviewed
Aug 8, 2025
| if ( | ||
| is.numeric(color) && length(color) == 3 && all(color >= 0 & color <= 255) | ||
| ) { | ||
| return(paste0("rgb(", paste(color, collapse = ", "), ")")) |
Contributor
There was a problem hiding this comment.
I am not sure if this can happen if you import dataset from csv?
Contributor
Author
There was a problem hiding this comment.
Fair point 😅 but actually for quoted character values it is possible. We could give up on this check for simplicity's sake.
skvrnami
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #161.
New (sub)module to import codebooks from rectangular format (CSV/TSV) files.
Relies on a modal wizard, which gives users some leeway in how their import file is formatted.
Includes basic checks such as properly specified colors or unique code names.
At present, the following is supported:
Although this works and can be useful for some use cases, I think we need further steps to consider this feature complete:
These extensions will enable complete circulation of Requal codebooks via CSVs.
Also, when supported by Requal, we need to implement the following: