Fix /qs cleanghost issues with Folia scheduler#2247
Merged
creatorfromhell merged 2 commits intoQuickShop-Community:hikarifrom Feb 5, 2026
Merged
Fix /qs cleanghost issues with Folia scheduler#2247creatorfromhell merged 2 commits intoQuickShop-Community:hikarifrom
creatorfromhell merged 2 commits intoQuickShop-Community:hikarifrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the ghost shop cleaning command to improve concurrency and reliability. The main change is replacing the use of
BatchBukkitExecutorwith a more modern and thread-safe approach usingCompletableFutureandCopyOnWriteArrayList, which better supports concurrent operations and integrates with the Folia scheduler.Concurrency and task management improvements:
BatchBukkitExecutorfor shop deletion tasks with aCompletableFuture-based approach, usingCopyOnWriteArrayListto collect all asynchronous deletion tasks andCompletableFuture.allOfto wait for their completion. This provides better concurrency control and thread safety. [1] [2]