Skip to content

Fix /qs cleanghost issues with Folia scheduler#2247

Merged
creatorfromhell merged 2 commits intoQuickShop-Community:hikarifrom
wling-art:fix/sch
Feb 5, 2026
Merged

Fix /qs cleanghost issues with Folia scheduler#2247
creatorfromhell merged 2 commits intoQuickShop-Community:hikarifrom
wling-art:fix/sch

Conversation

@wling-art
Copy link
Contributor

This pull request refactors the ghost shop cleaning command to improve concurrency and reliability. The main change is replacing the use of BatchBukkitExecutor with a more modern and thread-safe approach using CompletableFuture and CopyOnWriteArrayList, which better supports concurrent operations and integrates with the Folia scheduler.

Concurrency and task management improvements:

  • Replaced the BatchBukkitExecutor for shop deletion tasks with a CompletableFuture-based approach, using CopyOnWriteArrayList to collect all asynchronous deletion tasks and CompletableFuture.allOf to wait for their completion. This provides better concurrency control and thread safety. [1] [2]
  • Integrated the Folia scheduler by running each shop deletion task at the shop's location, ensuring compatibility with Folia's region threading model.
  • Updated the completion logic to send a summary message to the user only after all deletion tasks are finished, ensuring accurate feedback.

@creatorfromhell creatorfromhell merged commit 54a0ba9 into QuickShop-Community:hikari Feb 5, 2026
2 checks passed
@wling-art wling-art deleted the fix/sch branch February 6, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants