Conversation
acl-cqc
approved these changes
Dec 3, 2024
Collaborator
acl-cqc
left a comment
acl-cqc
left a comment
There was a problem hiding this comment.
Looks good, thanks! A few suggestions but go ahead :)
brat/Brat/Checker.hs
Outdated
| @@ -724,7 +724,7 @@ checkBody fnName body cty = do | |||
| NoLhs tm -> pure (tm, (fcOf tm, fcOf tm)) | |||
| Clauses (c :| cs) -> do | |||
Collaborator
There was a problem hiding this comment.
To give a bit more of a clue what's going on, consider
Suggested change
| Clauses (c :| cs) -> do | |
| Clauses (c@(abs,tm) :| cs) -> do | |
| fc <- req AskFC | |
| pure (WC fc (Lambda c cs), (fcOf abs, fcOf tm) c) |
Co-authored-by: Alan Lawrence <alan.lawrence@quantinuum.com>
Co-authored-by: Alan Lawrence <alan.lawrence@quantinuum.com>
Co-authored-by: Alan Lawrence <alan.lawrence@quantinuum.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And other drive-by fixes pulled out from #59