Skip to content

Conversation

@Shnatsel
Copy link
Collaborator

@Shnatsel Shnatsel commented Jan 24, 2026

I've cleaned up the PoC and made it adapt to the native vector width.

This is a significant performance improvement across the board, barring the smallest sizes on Aarch64 which worked well enough with fully unrolled paths specialized for a single small size.

This is also a way forward for writing code that's "generic" over the f32/f64 types and native vector widths. The machine code is the same as if these were Rust generics (full monomorphization) but it's implemented via declarative macros. We can reuse this approach for DiT kernels later, which are currently copy-pasted.

Stacked on top of #58

Supersedes #62

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 98.14815% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.79%. Comparing base (6875e8c) to head (c34cce2).

Files with missing lines Patch % Lines
src/algorithms/bravo.rs 98.07% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   99.88%   99.79%   -0.10%     
==========================================
  Files          12       13       +1     
  Lines        2711     2867     +156     
==========================================
+ Hits         2708     2861     +153     
- Misses          3        6       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Shnatsel Shnatsel mentioned this pull request Jan 24, 2026
@Shnatsel Shnatsel marked this pull request as ready for review January 24, 2026 20:55
@Shnatsel Shnatsel merged commit 6db0aec into main Jan 24, 2026
10 checks passed
@Shnatsel Shnatsel deleted the fearless-bravo branch January 24, 2026 21:00
This was referenced Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants