Replace link extraction code with Rust #4548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
One or more of the following people are relevant to this code:
|
frankharkins
commented
Jan 16, 2026
Member
Author
There was a problem hiding this comment.
These tests are now in https://github.com/qiskit-community/mdx-link-extract/
| "- To install Python, first check the \"Programming Language\" section on the [Qiskit PyPI project page](https://pypi.org/project/qiskit/) to determine which Python versions are supported by the most recent release. For download instructions, see the [Python Beginners Guide.](https://wiki.python.org/moin/BeginnersGuide/Download)\n", | ||
| "\n", | ||
| "<Admonition type = \"note\">\n", | ||
| "<Admonition type=\"note\">\n", |
Member
Author
There was a problem hiding this comment.
The only discrepancy I found between the JS and Rust MDX libraries is that the Rust library doesn't allow spaces here. This only occurs in a handful of places in our repo.
arnaucasau
approved these changes
Jan 16, 2026
Collaborator
arnaucasau
left a comment
arnaucasau
left a comment
There was a problem hiding this comment.
Amazing work, Frank! I love the speedup we got, especially with the API check:
Before: ~6 min
Now: ~40s
I tested the link checker locally and everything worked as expected!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving check time is important to our team (see #2854). A large portion of the time is spent in the internal link checker.
We discovered that parsing markdown and extracting links is a bottleneck in the link checker, so we rewrote that specific function in Rust (https://github.com/qiskit-community/mdx-link-extract/). From eyeballing the logs, this brings roughly a 10x speedup.