Remove plotly figures from notebook #4545
Open
+35
−2,243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
One or more of the following people are relevant to this code: |
Collaborator
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Thanks! Notebook size matters for the web app performance + bundle size, so this is a solid improvement.
Comment on lines
441
to
+442
| "# Display the figure\n", | ||
| "fig.show(renderer=\"notebook\")\n", | ||
| "# fig.show(renderer=\"notebook\")\n", |
Collaborator
There was a problem hiding this comment.
I'm curious what the content team thinks, but it might be worth explaining what's going on. Like "Uncomment the below line to display the figure"
Collaborator
There was a problem hiding this comment.
Yes, I think it would help to be more specific in the way Eric suggests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plotly's interactive figures contain a lot of code: Some of it JSON (see this PR's diff), some of it HTML and JS (see #4539 (comment)). Since we can't display the figures on our website, I've commented out the two
fig.showlines. Users can uncomment them to render the figures in their local notebook client.