CHANGE catch Throwable instead of Exception

[ninovanhooff]

Why is this important?

There are some errors that are Throwables but not Exceptions. These need to be handled too. I had this happen af few times in my projects.

Notes

It seems catching exception is not idiomatic and bad practice in Kotlin: https://stackoverflow.com/a/64323675/923557

[sebaslogen]

Yes, we should never catch generic Exception, in theory.
The problem is that often developers create a custom errors extending from exception instead of Throwable. For example:

• In libraries where the error is recoverable, like this exception where we do want to catch that specific Exception:

  Template.Android/core/network/src/main/kotlin/nl/q42/template/core/network/logger/JsonFormattedHttpLogger.kt

  Line 15 in f7592a9

  } catch (e: JSONException) {

  
  In these cases, we do have to catch the specific Exception, never the catch all Exception class

[sebaslogen]

This is an example of where Exception catching was happening and it's not clear exactly what error was being catch.

If request() can throw an exception, like java.net.UnknownHostException we should catch that specific exception here instead of generic Exception. Plus all other recoverable Exceptions.
The request() function already returns a NetworkResponse<T, ApiErrorResponse> so the NetworkResponseAdapter library should take care of catching all these exception, which leaves me to the questions:

Is there any code inside the request() function that can throw a Throwable?
Are there other exceptions thrown inside the request() function that are not catch by the NetworkResponseAdapter library and we should recover from? E.g. parsing data