Skip to content

Cleanup github actions #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ninovanhooff merged 7 commits into from
Oct 17, 2025
Merged

Cleanup github actions #164

ninovanhooff merged 7 commits into from
Oct 17, 2025

Conversation

@ninovanhooff
Copy link
Collaborator

@ninovanhooff ninovanhooff commented Aug 8, 2025 •
edited
Loading

Why is this important?

  • cleanup unused github actions
  • add a check for signing config credentials so that no build time is wasted. Without this, a full build may be executed which will fail at the last step (signing) when secrets are not configured properly

Notes

ninovanhooff
ninovanhooff commented Aug 8, 2025
View reviewed changes
@ninovanhooff
REMOVE leftover workflows
2b8a2cc 
Template.Android-99 Migrate from using ENV vars to secret.properties
@ninovanhooff
ADD signingConfig check
b53dce5 
Template.Android-99 Migrate from using ENV vars to secret.properties
@ninovanhooff ninovanhooff changed the base branch from Template.Android-161-composite-actions to develop August 8, 2025 19:42
ninovanhooff
ninovanhooff commented Aug 8, 2025
View reviewed changes
@ninovanhooff
FIX release-notes typo for app distribution
c42d561 
Template.Android-99 Migrate from using ENV vars to secret.properties
@ninovanhooff
Merge remote-tracking branch 'origin/develop' into Template.Android-1…
b617517 
…61-99-merge
@ninovanhooff ninovanhooff changed the title Template.android 161 99 merge Cleanup github actions Oct 14, 2025
Frank1234
Frank1234 approved these changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@Frank1234 Frank1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with one comment!

I'll add another CI cleanup/update PR after yours is merged.

@ninovanhooff ninovanhooff merged commit e65d41f into develop Oct 17, 2025
3 checks passed
@ninovanhooff ninovanhooff deleted the Template.Android-161-99-merge branch October 17, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frank1234 Frank1234 Frank1234 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ninovanhooff @Frank1234