Remove pyomo.duality and pyomo.core.plugins.transform.model#3876
Merged
blnicho merged 3 commits intoPyomo:mainfrom Mar 20, 2026
Merged
Remove pyomo.duality and pyomo.core.plugins.transform.model#3876blnicho merged 3 commits intoPyomo:mainfrom
pyomo.duality and pyomo.core.plugins.transform.model#3876blnicho merged 3 commits intoPyomo:mainfrom
Conversation
mrmundt
approved these changes
Mar 20, 2026
blnicho
reviewed
Mar 20, 2026
Comment on lines
-91
to
-96
| self.run_bilevel(join(exdir, 't5.py')) | ||
| self.check('t5', 'linear_dual') | ||
|
|
||
| def test_t1(self): | ||
| self.problem = 'test_t1' | ||
| self.run_bilevel(join(exdir, 't1.py')) |
Member
There was a problem hiding this comment.
There are a couple example py files used in these tests that are not deleted in this PR. I'm guessing they aren't being tested anywhere else so I wonder if they should be removed.
blnicho
approved these changes
Mar 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3876 +/- ##
==========================================
+ Coverage 89.68% 89.92% +0.24%
==========================================
Files 908 901 -7
Lines 106764 106285 -479
==========================================
- Hits 95750 95581 -169
+ Misses 11014 10704 -310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This removes two {old, deprecated, poorly tested} pieces of Pyomo:
pyomo.duality- this package has been completely superseded by:pyomo.duality.lagrangian_dual(deprecated since 5.6.2) is completely replaced bypyomo.core.plugins.transform.lp_dualpyomo.duality.collectis replaced bypyomo.repn.plugins.standard_form. This is a more generalized and robust implementation (and with simpler, easier to use return data types)standard_formwriter that re-creates the old return types (which will resolve the bugs) and then immediately deprecate that method. Providing the deprecation path would be several hours of work.pyomo.core.plugins.transform.model(deprecated since 6.7.3) has been replaced bypyomo.repn.plugins.standard_formChanges proposed in this PR:
pyomo.dualitypyomo.core.plugins.transform.modelLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: