-
Notifications
You must be signed in to change notification settings - Fork 563
Update Config classes / testing / documentation #3790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3790 +/- ##
==========================================
+ Coverage 89.41% 89.43% +0.01%
==========================================
Files 909 909
Lines 105579 105586 +7
==========================================
+ Hits 94407 94426 +19
+ Misses 11172 11160 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrmundt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooo I like this.
Fixes # .
Summary/Motivation:
This PR was motivated by two new features in the Config system:
ConfigDict.add()should accept keyword arguments so that users can specify modifiers likevisibilitywithout explicitly creating theConfigValueConfigDictshould derive fromMutableMappingso that methods likeupdate()are defined / available.As part of implementing that, this PR made a number of other improvements
ConfigBase.__call__so that theConfigDict-specific logic is in an overload method onConfigDictgenerate_documentation()document_class_CONFIGenum(Flag,IntFlag,EnumType)Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: