Moving to BS5 with a bit of 3rd party updating

[trollfot]

This is a PR encompassing a few BS5 update for fields (classes) and a few upgrade of versions (tinyMCE, datepicker).
The PR is presented early to allow comments and change in direction.

[trollfot]

Addressing : #499

[trollfot]

Addressing: #452

[trollfot]

Addressing : #431

[trollfot]

Addressing: #448

[stevepiercy]

59 test failures: https://github.com/Pylons/deform/actions/runs/6956721991/job/18928147423?pr=531#step:7:6539. See https://github.com/Pylons/deform/blob/main/contributing.md#when-to-add-or-edit-functional-tests for how to fix the tests.

[trollfot]

I'm currently trying to touch a bit of everything in a "do it first then fix it" kind of way. I'll take care of the tests once we're happy with the fixes. This PR is by no means complete, it allows us to possibly communicate of the different issues. Sorry for the noise, if it produces any.

[stevepiercy]

Ah, OK, in that case, I converted this PR to Draft status, which implies, "Please don't review yet, I'm working on it." When ready, you can either @ me or request a review from me and others, and change the status to ready for review.

[trollfot]

The upload widget is flat out not working, because of the javascript behind it. This needs some heavier work.
In the meantime, checked inputs/password were altered to use an input group. this is a try out, and probably a matter of taste. The previous rendering was very unflattering, so...

[trollfot]

Starting working on the functional tests. They need a bit of love since the introduction of the html5 "required" changes a lot of the validation tests.

[stevepiercy]

@miohtama @mcdonc @ericof do any of you have any objection to adding both @delijati and @sbrunner as maintainers of Deform?

I'll give it another week, after which I'll add them as maintainers. Please let me know. Thank you!

[stevepiercy]

I got a thumbs up from @mcdonc, and no other responses, so I've invited @delijati and @sbrunner to the Pylons organization Deform team.

Once they've both accepted, and pinged me back here, then I'll add them as maintainers on PyPI. @delijati and @sbrunner would you please verify your PyPI usernames so I can add you there as well?

There will also be some housekeeping chores to do.

Thank you for your patience and stepping up to maintain this package.

[sbrunner]

Thanks @trollfot, my pypi user name is the same: sbrunner :-)

[stevepiercy]

@sbrunner PyPI invitation sent.

[delijati]

same pypi name is also delijati

[stevepiercy]

@delijati:

Error User 'delijati' does not have a verified primary email address and cannot be added as a Maintainer for project.

😢

Please verify your primary email and ping me back. Thank you!

[delijati]

@delijati:

Error User 'delijati' does not have a verified primary email address and cannot be added as a Maintainer for project.

😢

Please verify your primary email and ping me back. Thank you!

@stevepiercy Done sorry

[stevepiercy]

@delijati invitation sent. Also if you haven't yet done so, please enable 2FA. There are some mean people out there.

[delijati]

Now that the paperwork's done, @trollfot , could you fix that pull request so we can get it merged? seems to be only linting

[sbrunner]

@delijati you have write access on the GitHub repository?
I still have no write access to this repository.

[stevepiercy]

@sbrunner the team has write access. You're a member of the team, and should inherit that access. Can you provide more information, including what you tried and observed?

[stevepiercy]

[trollfot]

Hello. I fixed the tests. But there is a build issue on MacOS that prevents the CI to finish

[sbrunner]

Sorry, @stevepiercy, I didn't look correctly; it's OK :-)

[sbrunner]

@trollfot the Python 3.9 ends in one month, I think that we can completely remove it.

[trollfot]

MacOS still fails

[sbrunner]

Some of macos pass :-) => add

          - os: "macos-latest"
            py: "3.10" 

in exclude!

[sbrunner]

It still has an issue in MoneyInputWidgetTests!

[delijati]

Does anyone have objections to merging this? I updated http://5.75.157.57/ so everybody can have a look

[trollfot]

I've been ready for 2 years 👍

[sbrunner]

Do we create a version 3.0.0-rc1?

[delijati]

Yes. But for the final release we should cleanup the issues, docs, README a bit there are links that are outdated and so.

[delijati]

@trollfot can you fix that branch so we can merge this too Pylons/deformdemo#129