Conversation
… read names from a csv file
polyccon
force-pushed
the
Privacy-and-security
branch
from
a6476f6 to
4d09a74
Compare
polyccon
force-pushed
the
Privacy-and-security
branch
from
4d09a74 to
4008672
Compare
kynan
reviewed
Jul 20, 2019
meetup_ballot/ballot.py
Outdated
| logging.info( | ||
| "Bad Member name: {} (ID: {})".format(member_name, member_id) | ||
| ) | ||
| if member_id in read_name_exceptions(name_exceptions_csv): |
Contributor
There was a problem hiding this comment.
I think you want to move the call to read_name_exceptions outside the loop, otherwise the file will be re-read on every iteration.
Author
There was a problem hiding this comment.
Good point! Wasn't sure how to run the code end-to-end, did run the tests and they were passing but I think there is some bug somewhere in how unittest is set up in virtualenv, can we rely on Travis ?
Author
There was a problem hiding this comment.
Pushed changes, but I need to see how to run the tests properly!
meetup_ballot/ballot.py
Outdated
| def read_name_exceptions(name_exceptions_csv): | ||
| """ Read member names from csv files""" | ||
| member_ids = [] | ||
| with open(name_exceptions_csv, newline='') as name_exceptions: |
Contributor
There was a problem hiding this comment.
Is there a specific reason to disable translation of newlines?
polyccon
force-pushed
the
Privacy-and-security
branch
2 times, most recently
from
62b45ee to
32779cd
Compare
polyccon
force-pushed
the
Privacy-and-security
branch
from
32779cd to
d270c95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name_exceptions_csvfiledoes_member_name_looks_like_spamfunction