Commit 9cf61b1
committed
Address CodeRabbit AI review feedback
- Fix README CMake version mismatch: update from >=3.10 to >=3.16
to match CMakeLists.txt requirement
- Fix Windows MSVC import library conflict: when BUILD_BOTH_LIBRARIES is ON,
both static and shared libraries would produce cpp_dotenv.lib on Windows.
Add IMPORT_SUFFIX "_shared.lib" to the shared library's import library
to avoid this conflict on Windows/MSVC.1 parent 7bed243 commit 9cf61b1
2 files changed
+6
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
75 | 80 | | |
76 | 81 | | |
77 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
0 commit comments