Address remaining Copilot review feedback

- Add OUTPUT_NAME property so libraries are named correctly:
  * libcpp_dotenv.a (static) instead of libcpp_dotenv_static.a
  * libcpp_dotenv.so/.dylib (shared) instead of libcpp_dotenv_shared.so
- Enable CMAKE_POSITION_INDEPENDENT_CODE when building shared libraries
  to ensure static dependencies are compiled with -fPIC
- Document BUILD_BOTH_LIBRARIES option in README.md with usage examples

The OUTPUT_NAME property sets only the base name; CMake automatically
adds the correct platform-specific extension (.so on Linux, .dylib on macOS).

Author: renecannao

CMakeLists.txt

@@ -21,6 +21,12 @@ if(BUILD_BOTH_LIBRARIES AND BUILD_SHARED_LIBS)
     set(BUILD_SHARED_LIBS OFF CACHE BOOL "Build shared libraries" FORCE)
 endif()
 
+# When building shared libraries that link against static libraries,
+# we need position-independent code for the static libraries
+if(BUILD_SHARED_LIBS OR BUILD_BOTH_LIBRARIES)
+    set(CMAKE_POSITION_INDEPENDENT_CODE ON)
+endif()
+
 #------------------- SUBDIRECTORY ADDITION ------------------------------------
 
 add_subdirectory(common)
@@ -53,6 +59,8 @@ if(BUILD_BOTH_LIBRARIES)
     )
     target_include_directories(cpp_dotenv_static PUBLIC ${CPP_DOTENV_INCLUDE_DIRS})
     target_compile_options(cpp_dotenv_static PRIVATE ${CPP_DOTENV_COMPILE_OPTIONS})
+    # Set output name to libcpp_dotenv.a (instead of libcpp_dotenv_static.a)
+    set_target_properties(cpp_dotenv_static PROPERTIES OUTPUT_NAME cpp_dotenv)
 
     # Shared library
     add_library(cpp_dotenv_shared SHARED ${CPP_DOTENV_SRC})
@@ -62,6 +70,8 @@ if(BUILD_BOTH_LIBRARIES)
     )
     target_include_directories(cpp_dotenv_shared PUBLIC ${CPP_DOTENV_INCLUDE_DIRS})
     target_compile_options(cpp_dotenv_shared PRIVATE ${CPP_DOTENV_COMPILE_OPTIONS})
+    # Set output name to libcpp_dotenv.so/.dylib (instead of libcpp_dotenv_shared.so)
+    set_target_properties(cpp_dotenv_shared PROPERTIES OUTPUT_NAME cpp_dotenv)
 
     # Alias for backward compatibility:
     # When BUILD_BOTH_LIBRARIES is ON, the cpp_dotenv target is an alias to

README.md

@@ -43,7 +43,7 @@ Supported build methods are:
 
 ### CMake
 
-**cpp-dotenv** comes with support for `CMake` right out of the box. In order to use it, simply include this repository's directory and link the `cpp_dotenv` target to your own targets where needed:
+**cpp-dotenv** comes with support for `CMake` right out of the box (>=3.16). In order to use it, simply include this repository's directory and link the `cpp_dotenv` target to your own targets where needed:
 
 ```cmake
 add_subdirectory(cpp-dotenv)
@@ -55,6 +55,42 @@ target_link_libraries(YOUR_TARGET cpp_dotenv)
 
 After this, you might use the library as described in [usage](#usage); no extra scoping, no need to worry about the project's directory structure.
 
+#### Build Options
+
+By default, only one library target named `cpp_dotenv` is built. The type of library (static or shared) is controlled by CMake's standard `BUILD_SHARED_LIBS` option:
+
+```bash
+# Build static library (default)
+cmake -DBUILD_SHARED_LIBS=OFF ..
+
+# Build shared library
+cmake -DBUILD_SHARED_LIBS=ON ..
+```
+
+#### Building Both Static and Shared Libraries
+
+To build both static and shared libraries in a single build directory, use the `BUILD_BOTH_LIBRARIES` option:
+
+```bash
+cmake -DBUILD_BOTH_LIBRARIES=ON ..
+```
+
+This creates two separate library targets:
+- `cpp_dotenv_static` - outputs as `libcpp_dotenv.a`
+- `cpp_dotenv_shared` - outputs as `libcpp_dotenv.so` (or `.dylib` on macOS)
+
+For backward compatibility, the `cpp_dotenv` target remains available as an alias to `cpp_dotenv_static`. If you need to link against the shared library, explicitly specify `cpp_dotenv_shared`:
+
+```cmake
+# Link against static library (default)
+target_link_libraries(YOUR_TARGET cpp_dotenv)
+
+# Link against shared library
+target_link_libraries(YOUR_TARGET cpp_dotenv_shared)
+```
+
+**Note:** When `BUILD_BOTH_LIBRARIES` is enabled, `BUILD_SHARED_LIBS` is ignored. Do not use both options simultaneously.
+
 ## Usage
 
 To be able to use the dotenv classes, simply include the main header file: