Resolve dynamic dispatch todos #3110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
commented
Jan 22, 2026
vicsn
force-pushed
the
resolve_dynamic_dispatch_todos
branch
2 times, most recently
from
1413184 to
dab0e49
Compare
Antonio95
approved these changes
Jan 28, 2026
Contributor
Antonio95
left a comment
Antonio95
left a comment
There was a problem hiding this comment.
Left a couple of minor comments. Happy to give this the green light even if those are disregarded.
vicsn
force-pushed
the
resolve_dynamic_dispatch_todos
branch
from
dab0e49 to
fafcae1
Compare
d0cd
reviewed
Feb 5, 2026
Collaborator
Author
|
@d0cd pushed another set of commits to re-enable recursion, which I recall was still on our wishlist. |
…lve_dynamic_dispatch_todos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves a few of the outstanding dynamic dispatch TODOs, can be reviewed commit-per commit.