-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[Feature] Filesystem reorganization #4033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e62037 to
66e9415
Compare
I think documentation in the snarkOS README, release and release blog should be sufficient.
I think this may not reflect how important it is for validators to keep
Given that backups are essentially required are for validators, what about we make it a mandatory flag for |
66e9415 to
ddda90a
Compare
eef8c59 to
601266f
Compare
4a27527 to
7ce27dc
Compare
7ce27dc to
743f6df
Compare
vicsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
|
Note this may need a minor merge to include #4054 once it's ready |
ljedrz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the general direction, there are just a few errors left to iron out, especially this one.
Co-authored-by: ljedrz <3750347+ljedrz@users.noreply.github.com> Signed-off-by: vicsn <victor.s.nicolaas@protonmail.com>
ljedrz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one last comment, but LGTM otherwise 👍.
vicsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #4013.
This PR adds a new
node-datadirectory that contains all node-specific data (essentially everything but the ledger). This is located at~/.aleo/storage/node-data-{network_id}for production or./node-data-{network_id}-{dev}for development nodes. Alternatively, users can also pass a value to--node-dataand store the data at a custom path.At startup, a node will check for any files that indicate that the old storage format is used. In that case, a message is printed in how to migrate, and the node will not start. Additionally, the FAQ in the README contains information on how to migrate.
Alternatively, nodes can also be started with
--auto-migrate-node-datato do this automatically. This is not enabled by default out of extra precaution.