[Perf] Cache the block tree on shutdown #4017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Collaborator
|
Amazing! @ljedrz let @meddle0x53 know when this is ready for him to give the mainnet ledger load test another try. |
Collaborator
Author
|
Superseded by #4021. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the snarkOS counterpart to ProvableHQ/snarkVM#3030, targeting ProvableHQ/snarkVM#3026.
I've successfully run some local tests using it, and saving the block tree seems to work most of the time; I'll soon iron out some edge case that I've observed from time to time (with the worst case scenario being the status quo, i.e. a full rebuild of the block tree).
Filing as a draft, as it uses an external branch until the snarkVM changes are merged, plus that one edge case.