fix: advance instruction index after CastLossy#29097
Open
radik878 wants to merge 2 commits intoProvableHQ:masterfrom
Open
fix: advance instruction index after CastLossy#29097radik878 wants to merge 2 commits intoProvableHQ:masterfrom
radik878 wants to merge 2 commits intoProvableHQ:masterfrom
Conversation
Signed-off-by: radik878 <radikpadik76@gmail.com>
Collaborator
|
Thanks @radik878! Do you mind checking why your new test currently fails? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Aleo interpreter did not increment the instruction index after executing a CastLossy instruction. As a result, the same lossy cast could be re-executed indefinitely, effectively trapping the interpreter on that instruction.
Made CastLossy advance the instruction index in the same way as regular Cast, ensuring the Aleo instruction pointer progresses correctly after lossy casts.
Added a focused unit test that runs a tiny Aleo program containing a single cast.lossy instruction and asserts that the AleoExecution frame completes instead of looping, guarding against future regressions