fix(handle): missing maker/taker fee arrays in order deserialization#1952
Merged
ryanio merged 1 commit intoProjectOpenSea:mainfrom Mar 23, 2026
Merged
Conversation
ryanio
approved these changes
Mar 23, 2026
Collaborator
ryanio
left a comment
There was a problem hiding this comment.
LGTM. The ?? [] fallback for maker_fees and taker_fees is a solid defensive fix — the API response could omit these even though the type declares them as required. Test coverage is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a runtime edge case in order deserialization when fee arrays are missing from API responses.
Problem
deserializeOrderassumedmaker_feesandtaker_feesalways exist and called.map()directly.If either field is missing, SDK throws at runtime.
Fix
makerFees: (order.maker_fees ?? []).map(...)takerFees: (order.taker_fees ?? []).map(...)Tests
Added a unit test in
test/orders/utils.spec.tsto verify missing fee arrays deserialize to empty arrays instead of throwing.