fix(sdk): throw when both orders and orderHashes are passed#1951
Merged
ryanio merged 1 commit intoProjectOpenSea:mainfrom Mar 23, 2026
Merged
Conversation
ryanio
approved these changes
Mar 23, 2026
Collaborator
ryanio
left a comment
There was a problem hiding this comment.
LGTM. Good catch — silently dropping orderHashes when both params are provided is a real footgun. The guard is in the right place and the test is thorough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a silent logical bug in
cancelOrderswhere passing bothordersandorderHashessimultaneously causedorderHashesto be silently ignored.Problem
cancelOrdersaccepted bothordersandorderHashesas optional parameters but only validated that at least one was provided. When both were supplied, theif (orders) { ... } else if (orderHashes) { ... }branching logic would process onlyordersand droporderHasheswithout any warning or error.This means a caller who provided both expecting all of them to be cancelled would silently fail to cancel the
orderHashesentries.Fix
ordersandorderHashesare provided, throw immediately with a clear error message.test/sdk/cancelOrders.spec.ts.