fix(api): validate trait inputs in postCollectionOffer#1950
Merged
Conversation
Extract shared validateTraitParams helper used by both buildOffer and postCollectionOffer, closing the validation gap where postCollectionOffer accepted invalid/ambiguous trait inputs that buildOffer already rejected. Co-Authored-By: Johnny Guitar <103390490+lavidaloca26@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postCollectionOfferaccepted invalid/ambiguous trait inputs thatbuildOfferalready rejectedvalidateTraitParams()helper to eliminate code duplication (was ~44 lines copy-pasted in fix(api): validate trait inputs in postCollectionOffer #1947)postCollectionOfferBased on the work in #1947 by @lavidaloca26. The key improvement over the original PR is extracting the validation into a shared function rather than duplicating it.
Test plan
🤖 Generated with Claude Code