fix(malformed): Retry-After header parsing#1942
Merged
ryanio merged 1 commit intoProjectOpenSea:mainfrom Mar 18, 2026
Merged
Conversation
ryanio
approved these changes
Mar 18, 2026
Collaborator
ryanio
left a comment
There was a problem hiding this comment.
Solid fix — the current parseInt silently accepts malformed values like "5s". The tighter regex and Number.isSafeInteger check are the right approach. Tests look good too. LGTM!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Retry-Afterparsing so malformed numeric-like values are no longer treated as valid retry delays.What changed
Retry-Aftervalues5sand1.5This prevents incorrect retry delays when a proxy or upstream service returns an invalid
Retry-Afterheader.