fix(orders): fix nullish coalescing on toString in getNFTItems#1928
Merged
fix(orders): fix nullish coalescing on toString in getNFTItems#1928
Conversation
quantities[index].toString() throws TypeError when quantities[index] is undefined, making the ?? "1" fallback dead code. Use optional chaining so the default actually triggers. Co-Authored-By: viktohblake <damanygt@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quantities[index].toString() ?? "1"→quantities[index]?.toString() ?? "1"ingetNFTItemsWhen
quantities[index]isundefined(e.g., quantities array shorter than nfts array), calling.toString()throws aTypeErrorbefore the?? "1"fallback can execute. Optional chaining fixes this so the default correctly triggers.Based on #1922 by @Viktohblake — thank you for catching this bug!
Test plan
npm testpasses"1"🤖 Generated with Claude Code