Frontend rework for Cruise Screening #253
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workshop-2/initial_frontend Initial frontend
…ript Installation script for ubuntu
…workshop-2/4-migrate-to-react-homeabouthtml 4 migrate to react homeabouthtml
…-workshop-2/fixing-react-warnings Fixes in Base, Home and Footer
…-workshop-2/7-migrate-to-react-pages-users 7 migrate to react pages users
…gic, connected it to frontend, added jwt token refreshing
…-workshop-2/12-implement-authentication-mechanism made logging in working
…-workshop-2/14-implement-editing-profile-details-frontend-and-new-api-endpoint implemented profile edition mechanisms
in order for footer to stick to the bottom, main part of the page expands thus allowing the correct footer positioning
add colors, and change layout
searchbar as well as the submit button are now coloured properly with shades of orange
Sign up page is now properly styled with the similar classes as the sign in page
1. `/frontend` has now separate Dockerfile for development (`Dockerfile.dev`) and production (`Dockerfile.prod`) 2. docker-compose.yml has now support for all application services 3. docker-compose.yml supports service profiles to smoothly run either dev or prod environment
README.md files were added in order to provide clear instructions for running the application in the contenerized environment
search is now divided into list elements with proper styling and placement
Proper colour handling was applied due to some inconsitancies from earlier.
also main color has been changed
Feature/search UI
kubijaku
requested review from
AyahSoufan,
WojciechKusa,
aminvenv and
ospitia
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request introduces significant changes to the
cruise_literatureproject, focusing on enhancing the application's infrastructure, removing deprecated files, and improving configuration for Docker-based deployment. The most important changes include the addition of Docker support for backend and frontend services, removal of unused scripts and files, and updates to settings and environment configurations.Infrastructure and Deployment Enhancements:
Addition of Docker Support: Introduced Dockerfiles and a docker-compose.yml file to streamline deployment of backend, frontend, and supporting services like PostgreSQL and Elasticsearch. This includes profiles for development (dev), production (prod), and additional services (search, es). ([1], [2])
Entrypoint Script for Backend: Added entrypoint.sh to handle database migrations, load initial data, and start the Django backend server. (src/cruise_literature/entrypoint.shR1-R29)
Codebase Cleanup:
Removal of Deprecated Scripts: Deleted unused scripts for data processing (get_AMiner.py, filter_AMiner.py, concept_rate.py) and their associated README files. ([1], [2], [3], [4])
Simplification of docker-compose.yml in Backend: Updated the backend's Docker configuration to use a unified Dockerfile instead of search_app.Dockerfile. (src/backend/docker-compose.ymlL11-R10)
Frontend changes
UI rework: ui is consistant across all pages making it future-proof and easy to work with. This is due to introduction of tailwind.css for styling components. Custom colours were defined in tailwind.config file and applied, which makes it easily changeable if needed.
Dark mode: we introduced dark mode to the ui design which is applicable by the header toggle
Configuration Updates:
Environment Variables for PostgreSQL: Updated setup_cruise.sh with placeholder values for PostgreSQL credentials and disabled unnecessary installations. (setup_cruise.shL10-R47)
Documentation Improvements:
Expanded Documentation: Added a detailed README for the src directory explaining the application's services, Docker profiles, and deployment instructions. (src/README.mdR1-R51)