Skip to content

Conversation

@ilicfilip
Copy link
Collaborator

We had PP icon hard coded on Editor screen (it is used to toggle PP sidebar). This PR does following:

  • Replace hardcoded SVG icon in block editor with branding-aware icon from the branding system
  • Add $raw parameter to get_admin_menu_icon() to return either base64 data URI or raw SVG markup
  • Render icon as inline SVG for CSS styling support (white icon when sidebar is active)

@ilicfilip ilicfilip added this to the 1.10.0 milestone Jan 27, 2026
@ilicfilip ilicfilip requested a review from aristath January 27, 2026 10:33
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Test merged PR on Playground
Test this pull request on the Playground
or download the zip

@github-actions
Copy link
Contributor

✅ Code Coverage Report

Metric Value
Total Coverage 31.61% 📉
Base Coverage 31.61%
Difference 📈 0.00%

⚠️ Coverage below recommended 40% threshold

🎉 Great job maintaining/improving code coverage!

📊 File-level Coverage Changes (2 files)

📈 Coverage Improved

Class Before After Change
Progress_Planner\UI\Branding 33.33% 33.64% +0.31%

📉 Coverage Decreased

Class Before After Change
Progress_Planner\Admin\Editor 4.76% 4.55% -0.21%
ℹ️ About this report
  • All tests run in a single job with Xdebug coverage
  • Security tests excluded from coverage to prevent output issues
  • Coverage calculated from line coverage percentages

@aristath aristath merged commit eff059c into develop Jan 27, 2026
20 of 21 checks passed
@aristath aristath deleted the filip/editor-icon branch January 27, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants