-
Notifications
You must be signed in to change notification settings - Fork 0
Merge latest changes for zlib 1.3.1 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Used an LLM aka GitHub Copilot to generate this.
Add basic CI
ci: add dependabot for automatic dependency PRs
refactor: switch to git submodule v1.3.1 of zlib
|
Needed to fix the CI here now, but that seems to work. Also ran the benchmark here: https://github.com/PrivateBin/zlib-wasm-without-emscripten-sample/actions/runs/21549231403 |
|
Benchmark result: |
|
BTW renamed the branched and switched to main: https://github.com/PrivateBin/zlib-wasm-without-emscripten-sample |
|
I was still working on the branch to get that CI to work, but its pretty busy and I wont get back to it until the weekend after the coming one. ATM it fails badly but I don't understand why as it was still working locally on my x86 host - maybe an incompatibility of one of the used node modules with the node version used in Github actions? I was trying to replace the node-based stuff with ancient stripped-down emscripted-"light" toolchain with an emscripten-in-a-container based workflow, so I can also use it on my aarch64 system that I use for most privatebin work these days. That requires re-writing the C-code that exposes the library functions and I hadn't yet fully grokked emscripten headers. I don't mind merging this once the CI works and once I can conclude my work I can push that as a separate branch instead of working on top of this one. |
If this is done, IMHO, we can also change the main branch, IMHO.