Add fallback to curl when allow_url_open is disabled; error if curl not available.

[instancezero]

Questions	Answers
Description?	Fallback to curl when retrieving update list; detect when curl is also missing.
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #1562
Sponsor company	Abivia Inc. @abivia
How to test?	Run update assistant when allow_url_fopen is off, verify update list is retrieved (I have tested this on a live system but haven't rebuilt a PHP with no curl, just handling the edge case here.)

[Quetzacoalt91]

Thanks @instancezero, would it be possible to export this code in a dedicated method?
There is at least two occurrences from where we could enjoy the change: https://github.com/PrestaShop/autoupgrade/pull/1602/changes

The change could be in classes/Services/DownloadService.php next to the existing download() method.

[instancezero]

Thanks @instancezero, would it be possible to export this code in a dedicated method? There is at least two occurrences from where we could enjoy the change: https://github.com/PrestaShop/autoupgrade/pull/1602/changes

The change could be in classes/Services/DownloadService.php next to the existing download() method.

It is possible. Can you suggest a method name?

Another option would be to make the $destinationPath argument nullable, change the return type to ?string (and then string|void when minimum PHP is raised to 8.3) and have the download() method return the string when no destination is provided.

[Quetzacoalt91]

It is possible. Can you suggest a method name?

Another option would be to make the $destinationPath argument nullable, change the return type to ?string (and then string|void when minimum PHP is raised to 8.3) and have the download() method return the string when no destination is provided.

We can use something like "fetchContents" or "getContents" to distinguish them from the method download() that stores on the filesystem.
I wouldn't modify the existing method, because it handle file contents as streams, alowing us to download the module to download huge amount of data without using too much memory and in consequence not reaching the memory limit exception.

[instancezero]

I thought about this some more and came to the same conclusion about modifying download().

I also neglected to mention that the latest commit implements fetch() as a static method. Instantiating the class would require passing a Translator and a Logger, and the translator requires a base path, all of which seems like unnecessary overhead to me.

[Quetzacoalt91]

Excellent, if you can rebase your branch to solve the conflict, we should be good to go

[instancezero]

That should do it...

[Quetzacoalt91]

Thank you very much.

[AureRita]

Hi @instancezero

Thank you for your PR, unfortunately, this one is still in conflict. Even without this conflict, I was able to test the PR and we get a 500 error even when we have allow_url_fopen = On, as you can see :

Capture.video.du.2026-02-03.12-11-54.mp4

You can see that all CI is red because of this issue

Waiting for feedback

[instancezero]

I'll take a look. The issue is the change to the constructor, which is breaking other parts of the code.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud