Improving Log performance Update 9.1.0.sql#1466
Open
Prestaworks wants to merge 1 commit intoPrestaShop:devfrom
Open
Improving Log performance Update 9.1.0.sql#1466Prestaworks wants to merge 1 commit intoPrestaShop:devfrom
Prestaworks wants to merge 1 commit intoPrestaShop:devfrom
Conversation
Contributor
|
Sorry i say a mistake you need to rebase : PrestaShop/PrestaShop#39550 (review) |
Prestaworks
force-pushed
the
for-PR-39550
branch
from
6c7545b to
f95b39f
Compare
Contributor
|
I updated the title |
upgrade/sql/9.1.0.sql
Outdated
Member
There was a problem hiding this comment.
- What's the use of
(3072)? - Please add an empty line at the end of the file.
Contributor
Author
There was a problem hiding this comment.
it came from mariadb limiting the length of the key, I changed the column to CHAR 32 instead since it's a md5 hash it should be enough.
Contributor
Author
it's moved here PrestaShop/PrestaShop#39566 the other one closed when i tried to remove the merge commits |
Update 9.1.0.sql Update upgrade/sql/9.1.0.sql Co-Authored-By: Thomas N <Quetzacoalt91@users.noreply.github.com>
Prestaworks
force-pushed
the
for-PR-39550
branch
from
555f613 to
1849d03
Compare
|
Quetzacoalt91
approved these changes
Sep 17, 2025
Quetzacoalt91
added
Blocked
Member
|
Blocked until PrestaShop/PrestaShop#39566 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.