fix: resolve duplicate testimonial mapping in Testimonial section (#938)#942
Open
Pratik-1213 wants to merge 1 commit intoPremkolte:mainfrom
Open
fix: resolve duplicate testimonial mapping in Testimonial section (#938)#942Pratik-1213 wants to merge 1 commit intoPremkolte:mainfrom
Pratik-1213 wants to merge 1 commit intoPremkolte:mainfrom
Conversation
|
@Pratik-1213 is attempting to deploy a commit to the premkolte's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
✨ Hi @Pratik-1213! Thanks for submitting another pull request. Your continuous improvements are highly valued. Keep contributing! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Problem
The "Loved by developers" testimonial section on the landing page displayed the same
set of testimonials twice visibly due to a naive array duplication (
[...testimonials, ...testimonials])with a hardcoded
translateX(-50%)scroll animation.Fix
getUniqueTestimonials()helper — deduplicates testimonials byidusing aSet,preventing any future duplicate data entries from showing up
useRef+useEffectto measure the exact pixelwidth of one set of testimonials, then scrolls by that exact amount instead of a hardcoded
50%.This ensures the infinite loop resets seamlessly without visible duplication
scroll velocity across all screen sizes
will-change: transformfor smoother GPU-accelerated animationuseMemoto avoid unnecessary re-computationFiles Changed
src/Pages/Home/Testimonial.jsxRelated Issue
Closes #938
Checklist:
Please mention these details about yourself here.