bug-fix-missing horizontal scroll bar at the preview data and app bre… #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aks after first analysis run.
NKeleher
approved these changes
Dec 1, 2025
NKeleher
left a comment
NKeleher
left a comment
There was a problem hiding this comment.
Works great for me! A few comments to attend to before merging. Thanks for you work on this @Ebenezer5542!
Horizontal scrolling works!
| content=preview_table, | ||
| content=ft.Row( | ||
| controls=[preview_table], | ||
| scroll=ft.ScrollMode.AUTO, # I added this to enable horizontal scroll |
There was a problem hiding this comment.
🎉 Thanks for adding the horizontal scroll! Works great for me. Could you remove the comment?
| padding=8, | ||
| border_radius=4, | ||
| ), | ||
| # ft.Container( |
There was a problem hiding this comment.
⭐ ⭐ If we no longer need this container, please delete the code for easier code maintenance.
|
|
||
| def on_screen_enter(self): | ||
| """Enter this screen and reset analysis state.""" | ||
| print("DEBUG: on_screen_enter() called") |
There was a problem hiding this comment.
⭐ remove, or comment out, the DEBUG print statements before merging.
Collaborator
Author
There was a problem hiding this comment.
Debug line commented out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added horizontal scrollbar to Results screen
The data preview table previously had no horizontal scrollbar, causing wide datasets to appear misaligned and difficult to read. I added a horizontal scrollbar so wider data now displays cleanly.
Fixed logic issue on Progress screen
There was a bug where, after completing the first analysis run, the app required a restart before running again.
I resolved this by resetting the analysis_complete flag to False inside on_state_changed, ensuring the flags properly resets between runs.