fix: copy Android JNI libs as libapp.a to match uniffi-generated CMakeLists#153
Merged
fix: copy Android JNI libs as libapp.a to match uniffi-generated CMakeLists#153
Conversation
…eLists uniffi-bindgen-react-native generates CMakeLists.txt referencing libapp.a (based on the Rust crate name), but the flake was copying the library as libportal.a. This caused Android builds to fail with: ninja: error: 'src/main/jniLibs/arm64-v8a/libapp.a' missing Fix: keep the destination filename consistent with the crate name (app).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the rearchitecture in #133 (crate renamed
app→portal-app→ reverted back toapp), thereact-native/flake.nixwas updated to copy the Android JNI libraries under the wrong filename:uniffi-bindgen-react-nativegenerates aCMakeLists.txtthat references the library by the Rust crate name — which isapp, so it looks forlibapp.a. Since the flake was copying it aslibportal.a, the Android build failed:Fix
Keep the destination filename consistent with the crate name: