Handle newer dockerd versions + misc cleanups #183
+216
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaty
reviewed
Jan 21, 2026
RemiCardona
force-pushed
the
fix_newer_dockerd
branch
from
f120f08 to
7e37d6d
Compare
Comment on lines
+157
to
+158
| # hopefully, there's only one network defined (e.g. 'bridge') so let's try and use that one | ||
| # if there are more, let's hope that the first one that comes up is the one we care about |
There was a problem hiding this comment.
how about we log something if we have more than 1 ?
Contributor
Author
There was a problem hiding this comment.
good idea, will do
vbourgeois90
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.