Feat: import monitoring sites groups#575
Draft
IdrissaD wants to merge 7 commits intoPnX-SI:feat/import-monitoringfrom
Draft
Feat: import monitoring sites groups#575IdrissaD wants to merge 7 commits intoPnX-SI:feat/import-monitoringfrom
IdrissaD wants to merge 7 commits intoPnX-SI:feat/import-monitoringfrom
Conversation
IdrissaD
force-pushed
the
feat/import-monitoring-sites-groups
branch
from
d687d99 to
acdc1ba
Compare
jacquesfize
force-pushed
the
feat/import-monitoring
branch
from
3d34ad8 to
b509eca
Compare
IdrissaD
force-pushed
the
feat/import-monitoring-sites-groups
branch
from
acdc1ba to
0d9c0a0
Compare
edelclaux
reviewed
Feb 19, 2026
| id_destination=id_destination, | ||
| bib_themes=bib_themes, | ||
| is_parent_link=True, | ||
| ) |
There was a problem hiding this comment.
un des get_cor_entity_field a disparu dans cette histoire. C4est normal ?
edelclaux
reviewed
Feb 19, 2026
| @@ -1,30 +1,30 @@ | |||
| from gn_module_monitoring.monitoring.import_actions.visit_actions import VisitImportActions | |||
| from .entity_import_actions_utils import EntityImportActionsUtils | |||
There was a problem hiding this comment.
je trouve bizarre toutes ces modfis la (tout le fichier). C4est pas une fausse manip ?
edelclaux
reviewed
Feb 19, 2026
| @@ -1,23 +1,31 @@ | |||
| from flask import current_app | |||
| from .entity_import_actions_utils import EntityImportActionsUtils | |||
There was a problem hiding this comment.
pareil, toutes ces modifs d'import sont étranges.
edelclaux
reviewed
Feb 19, 2026
| imprt, SitesGroupImportActions.ENTITY_CODE | ||
| ) | ||
|
|
||
| if SitesGroupImportActions.ID_FIELD: # FIXME |
Author
There was a problem hiding this comment.
J'avais oublié d'enlever cette ligne qui ne fonctionnait même pas comme prévu. Remplacé par dbd3ac6#diff-9951c3fbfb0a9107563934d70e23e7706c50ce37d9a079f232d1e03f94cdf8b7R322
Mais je suis pas satisfait de la gestion de ce check, qui peut laisser passer des erreurs dans le cas suivant :
- module avec groupes de sites activés
- groupes de sites non obligatoires (entité "site" au même niveau que "sites_group" dans config.json d'un protocole)
- uuid_group quand même renseigné à l'import d'un site, mais cet uuid ne correspond à aucun groupe
edelclaux
reviewed
Feb 19, 2026
| @@ -1,34 +1,36 @@ | |||
| from .entity_import_actions_utils import EntityImportActionsUtils | |||
| from geonature.core.imports.checks.sql.parent import set_parent_line_no | |||
| from geonature.utils.env import db | |||
IdrissaD
commented
Feb 19, 2026
| if SitesGroupImportActions.ID_FIELD: # FIXME | ||
| if ( | ||
| isSitesGroupMandatory | ||
| ): # FIXME : idéalement vérifier chaque ligne pour appliquer la vérification uniquement en cas de présence d'un id_parent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #574
id_importàTMonitoringSitesGroupsDépend de la PR #573 pour une fonction.