Open
Conversation
TheoLechemia
force-pushed
the
feat/add_family_filter
branch
from
2f08832 to
498f072
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #667 +/- ##
===========================================
+ Coverage 53.96% 54.21% +0.25%
===========================================
Files 39 39
Lines 2763 2763
===========================================
+ Hits 1491 1498 +7
+ Misses 1272 1265 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheoLechemia
force-pushed
the
feat/add_family_filter
branch
from
e22da79 to
b325adf
Compare
Member
Author
|
J'ai rajouté un test sur le filtre ajouté, je sais pas trop pourquoi le codecov a baissé ? |
jacquesfize
reviewed
Jan 12, 2026
Contributor
jacquesfize
left a comment
jacquesfize
left a comment
There was a problem hiding this comment.
Il faudrait trouver un moyer de récupérer les index des columns. Un simple indexOf ?
apptax/tests/test_admin.py
Outdated
| sort_desc=None, | ||
| search=None, | ||
| # WARNING : le premier element du tuple est l'indice du tableau `column_filters` de la class Admin -> volatile ! | ||
| filters=[(5, "Famille", "Arachnidiidae")], |
Contributor
There was a problem hiding this comment.
passer par indexOf sur l'attribut column_filters pour récupérer cette index ?
amandine-sahl
force-pushed
the
feat/add_family_filter
branch
from
b325adf to
5a7ddc6
Compare
| for tax in results: | ||
| assert tax.famille == "Arachnidiidae" | ||
|
|
||
| def test_filter_familly(self): |
Contributor
There was a problem hiding this comment.
test_filter_familly a renommer en test_filter_order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ajoute un filtre par famille sur taxref