Depend on ros_environment for Humble detection #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR PlotJuggler#98 mistakenly removed ros_environment from package.xml. This broke Humble detection, which had to be worked around in 9b03f97 ("try detecting Humble in the build farm", 2025-06-10). This PR adds ros_environment dependency back and removes the Humble detection workaround. This also helps with building the package using the Nix package manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #98 mistakenly removed
ros_environmentfrompackage.xml. This broke Humble detection, which had to be worked around in 9b03f97 ("try detecting Humble in the build farm", 2025-06-10).This PR adds
ros_environmentdependency back and removes the Humble detection workaround.This also helps with building the package using the Nix package manager.