Skip to content

chore(ci): pre-commit autoupdate#4381

Closed
pre-commit-ci[bot] wants to merge 1 commit intomainfrom
pre-commit-ci-update-config
Closed

chore(ci): pre-commit autoupdate#4381
pre-commit-ci[bot] wants to merge 1 commit intomainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci
Copy link
Copy Markdown
Contributor

@pre-commit-ci pre-commit-ci bot commented Mar 23, 2026

updates:
- [github.com/gitleaks/gitleaks: v8.30.1 → v8.30.0](gitleaks/gitleaks@v8.30.1...v8.30.0)
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dillon-zheng for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 23, 2026

Hi @pre-commit-ci[bot]. Thanks for your PR.

I'm waiting for a PingCAP-QE member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

@ti-chi-bot ti-chi-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR updates the pre-commit configuration by downgrading the gitleaks hook version from v8.30.1 to v8.30.0. The change is minimal and straightforward, involving only a single line in the .pre-commit-config.yaml file. Overall, the PR is low risk and well-scoped.


Critical Issues

  • None identified. The version downgrade is unlikely to introduce bugs or security issues but should be verified to ensure it was intentional.

Code Improvements

  • None necessary as the change is simple and correct in syntax.

Best Practices

  • .pre-commit-config.yaml (line 13):
    • The PR description states an autoupdate, but the version is downgraded (v8.30.1 → v8.30.0). This is unusual for an autoupdate process. Please verify if this downgrade was intentional.
    • Suggestion: Add a short comment or PR description note explaining why the version was downgraded to avoid confusion for reviewers and future maintainers.
# Downgraded gitleaks from v8.30.1 to v8.30.0 due to [reason, e.g., compatibility issue]
rev: v8.30.0
  • Consider running pre-commit install and pre-commit run --all-files locally to verify the hooks work correctly at the downgraded version.

No further action required unless the downgrade was accidental.

@ti-chi-bot ti-chi-bot bot added the size/XS label Mar 23, 2026
@wuhuizuo wuhuizuo closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant