Skip to content

goproxy: normalize proxies for prow-jobs/tikv/pd#4313

Closed
Copilot wants to merge 3 commits intomainfrom
copilot/normalize-proxies-for-prow-jobs
Closed

goproxy: normalize proxies for prow-jobs/tikv/pd#4313
Copilot wants to merge 3 commits intomainfrom
copilot/normalize-proxies-for-prow-jobs

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 10, 2026

The release-6.1 PD presubmit job referenced an internal Kubernetes cluster DNS endpoint (goproxy.apps.svc) for Go module proxy, which is unreachable outside the cluster.

Changes

  • prow-jobs/tikv/pd/release-6.1-presubmits.yaml: Replace cluster-internal proxy with the official public endpoint:
# Before
- name: GO_PROXY
  value: http://goproxy.apps.svc,direct

# After
- name: GO_PROXY
  value: http://goproxy.pingcap.net,direct

Aligns with the proxy convention already in use across other prow-jobs (e.g., pingcap/tidb-engine-ext).

Original prompt

This section details on the original issue you should resolve

<issue_title>goproxy: normalize proxies for prow-jobs/tikv/pd</issue_title>
<issue_description>Replace internal goproxy endpoints for prow-jobs/tikv/pd with official/public proxies.

Acceptance criteria:

  • No internal goproxy endpoints in prow-jobs/tikv/pd
  • GOPROXY values set to default or official proxies
    </issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 10, 2026

Hi @Copilot. Thanks for your PR.

I'm waiting for a PingCAP-QE member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/XS label Mar 10, 2026
Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace internal goproxy endpoints for prow-jobs/tikv/pd goproxy: normalize proxies for prow-jobs/tikv/pd Mar 10, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wuhuizuo wuhuizuo closed this Apr 8, 2026
@wuhuizuo wuhuizuo deleted the copilot/normalize-proxies-for-prow-jobs branch April 8, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

goproxy: normalize proxies for prow-jobs/tikv/pd

2 participants