Skip to content

singleton pattern removal and pre-commit hook #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sk4x0r merged 12 commits into from
Nov 10, 2025
Merged

singleton pattern removal and pre-commit hook #29

sk4x0r merged 12 commits into from
Nov 10, 2025

Conversation

@282000ypk
Copy link
Collaborator

@282000ypk 282000ypk commented Nov 4, 2025 •
edited
Loading

Changes:

  1. Updated below clients to not follow singleton pattern and storing instances in a map since this is not required anymore.
  • SubscriptionClient
  • CustomCheckoutClient
  • StandardCheckoutClient
  1. Added a pre-commit hook that check and apply code formatting.
  2. Added a new non-mandatory parameter "disablePaymentRetry" in createSdkOrder request
  3. minor plugin and code comment changes to support deployment in maven central

@282000ypk 282000ypk changed the title single pattern removal and pre-commit hook singleton pattern removal and pre-commit hook Nov 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 10, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sk4x0r sk4x0r merged commit bf7167a into main Nov 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@282000ypk @sk4x0r